JDLOBrew/eden
16
0
Fork 0
Code Pull Requests Actions Packages Releases 4 Activity

[vk. texture_cache] WIP: Identity Swizzle must be compiliant to VK SPECS.

Browse Source
This commit is contained in:
CamilleLaVey
2025-11-21 12:11:30 -04:00
parent d53225835a
commit 3b95438059
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/video_core/renderer_vulkan/vk_texture_cache.cpp
View File

@@ -2170,8 +2170,15 @@ ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::ImageViewI
// Vulkan spec: STORAGE_IMAGE and INPUT_ATTACHMENT descriptors MUST use identity swizzle
// Using non-identity swizzle causes validation error and undefined behavior
// IMPORTANT: Only force identity swizzle for render targets OR input attachments.
// For sampled textures (even if they have storage capability), use the shader-specified
// swizzle to avoid breaking UE4 lighting and other games. The actual storage writes happen
// through StorageView() which uses MakeView() with hardcoded identity swizzle, so that
// path is already spec-compliant.
const bool is_input_attachment =
(image_view_usage.usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0;
const bool requires_identity_swizzle = Settings::values.force_identity_swizzle.GetValue() &&
(image_view_usage.usage & (VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) != 0;
(info.IsRenderTarget() || is_input_attachment);
const VkImageViewCreateInfo create_info{
.sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,