From ca0bc65531acbf0a9dc604765fbd287bd5f657db Mon Sep 17 00:00:00 2001 From: lizzie Date: Fri, 7 Nov 2025 16:58:41 +0100 Subject: [PATCH] [cmake] fix compilation for Intel Atom N455 (#2872) Patience is key when building from source on an Intel Atom N455. Of course, no SSE4.1 is in an atom... which is so unfortunate :( We only get SSSE3 - but CI handles for building better codegen doesn't it? Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2872 Reviewed-by: Caio Oliveira Reviewed-by: crueter Co-authored-by: lizzie Co-committed-by: lizzie --- CMakeLists.txt | 2 +- src/CMakeLists.txt | 6 ++++-- src/video_core/CMakeLists.txt | 4 ---- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b9012d70b4..9ced1ff77a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -191,9 +191,9 @@ if (CXX_CLANG_CL) $<$:/EHsc> # thanks microsoft ) + # REQUIRED CPU features IN Windows-amd64 if (ARCHITECTURE_x86_64) add_compile_options( - # Required CPU features for amd64 $<$:-msse4.1> $<$:-mcx16> ) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 3e8a822ad9..81c2f81292 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -178,8 +178,10 @@ else() if (MINGW) add_compile_definitions(MINGW_HAS_SECURE_API) - add_compile_options("-msse4.1") - + # Only windows has this requirement, thanks windows + if (WIN32) + add_compile_options("-msse4.1") + endif() if (MINGW_STATIC_BUILD) add_compile_definitions(QT_STATICPLUGIN) add_compile_options("-static") diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index db99c2bcb9..f437663963 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt @@ -384,10 +384,6 @@ if (ARCHITECTURE_x86_64) macro/macro_jit_x64.h ) target_link_libraries(video_core PUBLIC xbyak::xbyak) - - if (NOT MSVC) - target_compile_options(video_core PRIVATE -msse4.1) - endif() endif() if (ARCHITECTURE_x86_64 OR ARCHITECTURE_arm64)