From b494b28f6f3b9072a56d0e5f372a862f60a9f3dd Mon Sep 17 00:00:00 2001 From: Zamitto <167933696+zamitto@users.noreply.github.com> Date: Sun, 5 Jan 2025 13:59:16 -0300 Subject: [PATCH] feat: sonar suggestions --- python_rpc/main.py | 2 +- src/main/services/hydra-api.ts | 3 ++- src/main/services/user/get-user-data.ts | 1 - src/preload/index.ts | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/python_rpc/main.py b/python_rpc/main.py index 03df83de..cc28d623 100644 --- a/python_rpc/main.py +++ b/python_rpc/main.py @@ -94,7 +94,7 @@ def seed_status(): @app.route("/healthcheck", methods=["GET"]) def healthcheck(): - return "", 200 + return "ok", 200 @app.route("/process-list", methods=["GET"]) def process_list(): diff --git a/src/main/services/hydra-api.ts b/src/main/services/hydra-api.ts index 16bbc21f..4446f664 100644 --- a/src/main/services/hydra-api.ts +++ b/src/main/services/hydra-api.ts @@ -32,7 +32,8 @@ export class HydraApi { private static readonly EXPIRATION_OFFSET_IN_MS = 1000 * 60 * 5; // 5 minutes private static readonly ADD_LOG_INTERCEPTOR = true; - private static secondsToMilliseconds = (seconds: number) => seconds * 1000; + private static readonly secondsToMilliseconds = (seconds: number) => + seconds * 1000; private static userAuth: HydraApiUserAuth = { authToken: "", diff --git a/src/main/services/user/get-user-data.ts b/src/main/services/user/get-user-data.ts index 7e924454..1b8cb1e0 100644 --- a/src/main/services/user/get-user-data.ts +++ b/src/main/services/user/get-user-data.ts @@ -42,7 +42,6 @@ export const getUserData = () => { }) .catch(async (err) => { if (err instanceof UserNotLoggedInError) { - logger.info("User is not logged in", err); return null; } logger.error("Failed to get logged user"); diff --git a/src/preload/index.ts b/src/preload/index.ts index 6a3a8758..d39d9a12 100644 --- a/src/preload/index.ts +++ b/src/preload/index.ts @@ -151,7 +151,8 @@ contextBridge.exposeInMainWorld("electron", { onAchievementUnlocked: (cb: () => void) => { const listener = (_event: Electron.IpcRendererEvent) => cb(); ipcRenderer.on("on-achievement-unlocked", listener); - return () => ipcRenderer.removeListener("on-achievement-unlocked", listener); + return () => + ipcRenderer.removeListener("on-achievement-unlocked", listener); }, /* Hardware */