Firehawk52-backup/dolphin
28
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-01-15 16:33:15 -03:00
Code Issues Actions Packages Projects Releases Wiki Activity

HotkeyManager: Don't allocate heap memory in GetInput

Browse Source 
Profiling Dolphin using Heaptrack, this turns out to be the cause of
more than half of all temporary allocations. Though since it's in a
separate thread, I suppose it wasn't affecting performance very much.
This commit is contained in:
JosJuice
2026-01-11 20:59:58 +01:00
parent 89a03199b1
commit 3c771ade4b
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Source/Core/Core/HotkeyManager.cpp
View File

@@ -11,6 +11,7 @@
#include <fmt/format.h>
#include <fmt/ranges.h>
#include "Common/Assert.h"
#include "Common/Common.h"
#include "Common/CommonTypes.h"
#include "Common/FileUtil.h"
@@ -360,17 +361,18 @@ InputConfig* HotkeyManager::GetConfig() const
void HotkeyManager::GetInput(HotkeyStatus* kb, bool ignore_focus)
{
std::array<u32, 32> bitmasks;
for (size_t key = 0; key < bitmasks.size(); key++)
bitmasks[key] = static_cast<u32>(1 << key);
const auto lock = GetStateLock();
for (std::size_t group = 0; group < s_groups_info.size(); group++)
{
if (s_groups_info[group].ignore_focus != ignore_focus)
continue;
const int group_count = (s_groups_info[group].last - s_groups_info[group].first) + 1;
std::vector<u32> bitmasks(group_count);
for (size_t key = 0; key < bitmasks.size(); key++)
bitmasks[key] = static_cast<u32>(1 << key);
const size_t group_count = (s_groups_info[group].last - s_groups_info[group].first) + 1;
ASSERT(group_count <= bitmasks.size());
kb->button[group] = 0;
m_keys[group]->GetState(&kb->button[group], bitmasks.data());
}